Skip to content

fix(dropdown): invalid dropdown menu position#4470

Closed
jijiseong wants to merge 1 commit into
heroui-inc:canaryfrom
jijiseong:fix/dropdown-position
Closed

fix(dropdown): invalid dropdown menu position#4470
jijiseong wants to merge 1 commit into
heroui-inc:canaryfrom
jijiseong:fix/dropdown-position

Conversation

@jijiseong
Copy link
Copy Markdown

@jijiseong jijiseong commented Dec 31, 2024

Closes #4466

📝 Description

useOverlay changes Placement type to PlacementAxis type.
bottom-end -> bottom
bottom -> bottom
bottom-start -> bottom

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Refactor
    • Simplified dropdown positioning logic
    • Removed overlay positioning calculations
    • Streamlined dropdown component props handling

The changes focus on improving the dropdown component's internal implementation, making it more straightforward and direct in managing placement properties.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 31, 2024

⚠️ No Changeset found

Latest commit: de4cc39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 31, 2024

@jijiseong is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 31, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the use-dropdown.ts file by simplifying the dropdown positioning logic. The changes involve removing the useOverlayPosition import and related positioning parameters from the useDropdown function. The overlay positioning calculations have been eliminated, and the placement is now directly assigned from the placementProp. This streamlines the dropdown's positioning mechanism by reducing complex positioning logic.

Changes

File Change Summary
packages/components/dropdown/src/use-dropdown.ts - Removed useOverlayPosition import
- Deleted positioning parameters: containerPadding, offset, crossOffset, shouldFlip
- Simplified placement logic by directly using placementProp

Assessment against linked issues

Objective Addressed Explanation
Fix Dropdown Arrow Positioning [#4466]

Possibly related PRs

Suggested reviewers

  • wingkwong
  • jrgarciadev

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d92468a and de4cc39.

📒 Files selected for processing (1)
  • packages/components/dropdown/src/use-dropdown.ts (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jijiseong jijiseong closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - DropDown arrow position

1 participant