chore(deps): framer-motion versions#3308
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: b4167eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update primarily focuses on synchronizing the version requirements for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (17)
- .changeset/pink-rivers-rush.md (1 hunks)
- packages/components/accordion/package.json (2 hunks)
- packages/components/autocomplete/package.json (1 hunks)
- packages/components/button/package.json (1 hunks)
- packages/components/calendar/package.json (1 hunks)
- packages/components/card/package.json (1 hunks)
- packages/components/dropdown/package.json (2 hunks)
- packages/components/modal/package.json (2 hunks)
- packages/components/navbar/package.json (1 hunks)
- packages/components/popover/package.json (2 hunks)
- packages/components/ripple/package.json (2 hunks)
- packages/components/select/package.json (2 hunks)
- packages/components/snippet/package.json (1 hunks)
- packages/components/tabs/package.json (2 hunks)
- packages/components/tooltip/package.json (2 hunks)
- packages/core/system/package.json (1 hunks)
- packages/utilities/framer-utils/package.json (1 hunks)
Files skipped from review due to trivial changes (9)
- .changeset/pink-rivers-rush.md
- packages/components/button/package.json
- packages/components/calendar/package.json
- packages/components/card/package.json
- packages/components/navbar/package.json
- packages/components/select/package.json
- packages/components/snippet/package.json
- packages/core/system/package.json
- packages/utilities/framer-utils/package.json
Additional comments not posted (15)
packages/components/ripple/package.json (2)
39-39: Updatedframer-motioninpeerDependenciesto>=11.0.22: This change is consistent with the PR's objective to update the version due to a bug fix in animations. It ensures that users of this package will have the required version that includes the necessary bug fixes.
51-51: Updatedframer-motionindevDependenciesto^11.1.7: This update aligns the development environment with the latest stable release offramer-motion, which likely includes additional fixes and improvements beyond the specific bug fix mentioned in the PR. It's good practice to keep development dependencies up to date.packages/components/tooltip/package.json (2)
39-39: Updatedframer-motioninpeerDependenciesto>=11.0.22: This change ensures that all consumers of the tooltip component are using a version offramer-motionthat includes the critical bug fix. This is crucial for maintaining the integrity and functionality of animations within the tooltip component.
62-62: Updatedframer-motionindevDependenciesto^11.1.7: Updating the development dependencies to the latest version helps in testing against the most recent features and bug fixes, ensuring that the tooltip component remains compatible and functional with newer versions of its dependencies.packages/components/dropdown/package.json (2)
39-39: Updatedframer-motioninpeerDependenciesto>=11.0.22: This update is critical for ensuring that the dropdown component works seamlessly with the latest animation features provided byframer-motion, especially since it likely involves dynamic display and hiding of elements.
64-64: Updatedframer-motionindevDependenciesto^11.1.7: Keeping the development environment updated with the latest versions of dependencies is essential for catching potential integration issues early in the development cycle. This change helps achieve that goal.packages/components/popover/package.json (2)
39-39: Updatedframer-motioninpeerDependenciesto>=11.0.22: Ensuring that the popover component, which likely relies heavily on animations for displaying overlays, uses an updated version offramer-motionis crucial for the smooth functioning of these animations.
66-66: Updatedframer-motionindevDependenciesto^11.1.7: This ensures that the development tests and builds are performed against the latest stable version offramer-motion, which supports the most recent bug fixes and features.packages/components/modal/package.json (2)
39-39: Updatedframer-motioninpeerDependenciesto>=11.0.22: The modal component, often involving animations for opening and closing, requires a robust animation library. This update guarantees that the necessary fixes inframer-motionare available to all consumers of the modal component.
67-67: Updatedframer-motionindevDependenciesto^11.1.7: Consistency in development dependencies ensures that developers are working with the most up-to-date versions, which can help prevent issues during development and testing phases.packages/components/tabs/package.json (2)
39-39: Updatedframer-motioninpeerDependenciesto>=11.0.22: For a component like tabs, which may involve transitions between tab content, it is essential to use an animation library that is free from critical bugs. This update ensures such reliability.
62-62: Updatedframer-motionindevDependenciesto^11.1.7: This update aligns the development dependencies with the latest stable version offramer-motion, facilitating the development and testing processes with the most recent enhancements and fixes.packages/components/accordion/package.json (2)
45-45: Approved version update inpeerDependencies.The update to
framer-motioninpeerDependenciesis aligned with the PR objectives and correctly formatted.
72-72: Approved version update indevDependencies.The update to
framer-motionindevDependenciesensures that the latest stable version is used, which is consistent with the PR objectives.packages/components/autocomplete/package.json (1)
39-39: Approved version update inpeerDependencies.The update to
framer-motioninpeerDependenciesfor the autocomplete component is consistent with the other package updates and addresses the bug fix mentioned in the PR description.
|
@wingkwong moving this to v2.5.0 since it might break some users' app |
* refactor(ripple): load domAnimation dynamically * refactor(modal): load domAnimation dynamically * refactor(accordion): load domAnimation dynamically * refactor(ripple): rename domAnimation * refactor(popover): load domAnimation dynamically * refactor(popover): load domAnimation dynamically * refactor(tooltip): load domAnimation dynamically * refactor(navbar): load domAnimation dynamically * refactor(tabs): load domAnimation dynamically * refactor(tabs): import only needed * refactor(navbar): load domAnimation dynamically * refactor(calendar): load domAnimation dynamically * refactor(components): revise extension * fix(modal): add content to memo dependency * refactor(accordion): move domAnimation outside AccordionItem * refactor(calendar): move domAnimation outside * refactor(components): move domAnimation outside * fix(navbar): remove duplicate definition * feat(utilities): @nextui-org/dom-animation * chore(deps): add @nextui-org/dom-animation package * chore: remove individual domAnimation * refactor(components): use @nextui-org/dom-animation instead * fix(navbar): remove duplicate definition * feat(changeset): add changeset * fix(tabs): use domMax instead * chore(deps): pnpm-lock.yaml * fix(tabs): discard dynamic load for domMax * chore(deps): framer-motion versions (#3308) * chore(deps): update framer-motion version in peerDependencies * chore(deps): sync framer-motion version across packages * chore(deps): pnpm-lock.yaml * feat(changeset): add changeset * chore(deps): sync framer-motion versions * refactor(tabs): add comments * chore(changeset): remove tabs
2 participants
Closes #
📝 Description
frame-motionin peerDependencies (set to11.0.22because of previousonly two keyframes currently supported with spring and inertia animationsbug fix)frame-motionin devDependencies across packages⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
framer-motiondependency to version^11.1.7across various components.peerDependenciesforframer-motionto>=11.0.22for better compatibility.These updates ensure improved performance and compatibility with the latest features of
framer-motion.