Skip to content

fix(dropdown): getMenuTriggerProps mergeProps#2450

Merged
jrgarciadev merged 4 commits into
heroui-inc:mainfrom
wingkwong:fix/eng-455
Mar 5, 2024
Merged

fix(dropdown): getMenuTriggerProps mergeProps#2450
jrgarciadev merged 4 commits into
heroui-inc:mainfrom
wingkwong:fix/eng-455

Conversation

@wingkwong
Copy link
Copy Markdown
Member

@wingkwong wingkwong commented Mar 5, 2024

Closes #2448

📝 Description

  • revised getMenuTriggerProps mergeProps logic

⛳️ Current behavior (updates)

  • originalProps will not be spread.
  • if isDisabled is not set, the value will be undefined

🚀 New behavior

  • originalProps will be spread.
  • if isDisabled is not set, the value will be false

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: bb8a863

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/dropdown Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 11:09am

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 5, 2024

@wingkwong is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - getMenuTriggerProps in use-dropdown.ts returns originalProps as Object

2 participants