fix(accordion): remove dividers from hidden accordion items#2219
Merged
jrgarciadev merged 3 commits intoMar 7, 2024
Conversation
🦋 Changeset detectedLatest commit: 97d7159 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ryo-manba is attempting to deploy a commit to the NextUI Team on Vercel. A member of the Team first needs to authorize it. |
ryo-manba
changed the title
Member
|
Thank you @ryo-manba could you please add the |
Contributor
Author
|
@jrgarciadev |
jrgarciadev
approved these changes
Mar 7, 2024
This was referenced Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2210
📝 Description
This PR addresses hidden AccordionItem components were still displaying dividers.
⛳️ Current behavior (updates)
In the current implementation, setting multiple
AccordionItemcomponents tohiddenstatus within anAccordionresults in stacking dividers. This behavior is inconsistent with the expected UI whenAccordionItemcomponents are hidden.🚀 New behavior
With this update, dividers associated with hidden
AccordionItemcomponents will no longer be displayed.💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information