Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

allowing for env override for "htts_only" #38

Closed
wants to merge 2 commits into from

Conversation

jmervine
Copy link

For non-prod environments, it would be helpful to override this value via the environment. Especially in dogwood, where a custom domain is required for https.

jmervine added 2 commits June 21, 2016 11:09
For non-prod environments, it would be helpful to override this value via the environment. Especially in dogwood, where a custom domain is required for https.
@jmervine
Copy link
Author

@hone Should I closet this, or do you think it's worth including. It's been so long I've lost context. Also I don't believe the failure is related to my PR

  1) Simple routes should support custom routes
     Failure/Error: expect(response.code).to eq("200")
     NoMethodError:
       undefined method `code' for nil:NilClass
     # ./spec/simple_spec.rb:70:in `block (4 levels) in <top (required)>'
     # ./spec/support/app_runner.rb:51:in `block in run'

Willing to look deeper at some point though.

@edmorley
Copy link
Member

edmorley commented Jun 9, 2022

Hi

This buildpack is now deprecated and we are recommending people move the more actively maintained heroku-buildpack-nginx. For migration advice see here.

As such, I'm closing this PR out since we won't be making further changes to this buildpack.

@edmorley edmorley closed this Jun 9, 2022
@edmorley edmorley deleted the jmervine-https_only-env branch June 9, 2022 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants