Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other pipenv versions than 2018.5.18 #906

Closed
wants to merge 1 commit into from
Closed

Allow other pipenv versions than 2018.5.18 #906

wants to merge 1 commit into from

Conversation

Thomas-Mollard
Copy link
Contributor

Following the issue #786 and the PR #820 that has not been merged (and is now out of date with the master branch), I am changing a bit the code of #820 to allow other pipenv versions to be installed while keeping the default at 2018.5.18

@Thomas-Mollard Thomas-Mollard requested a review from a team as a code owner December 4, 2019 18:44
@paulmelnikow
Copy link

paulmelnikow commented Mar 10, 2020

@CaseyFaist Can this be merged? I'm getting stuck on #704 and this would provide a workaround.

The problem with this version is that Dependabot creates a lockfile which works in CI, which has a later version of Pipenv, but it will not work in Heroku.

paulmelnikow added a commit to metabolize/rq-dashboard-on-heroku that referenced this pull request Mar 10, 2020
paulmelnikow added a commit to metabolize/rq-dashboard-on-heroku that referenced this pull request Mar 10, 2020
@CaseyFaist
Copy link
Contributor

Hi there! Thank you for your contribution ❤️ however since it's currently unclear how supported the pipenv project is, no pipenv feature requests are being prioritized at this time.

I am sorry about this frustration, however our version (2018.5.18) is only one version behind the current version (2018.11.26), and since pipenv vendors large chunks of pip into its source code, it's unclear which versions of pip the new version would be compatible with.

Also of note, the current pinned version of Pipenv would require users to uninstall and reinstall their local pipenv environments before being able to deploy again successfully to generate a valid pipfile. This is due to incompatibility with the lock files that is not autocorrected by pipenv's update function, and would lead to a lot of confusion for users attempting to update and expecting the updated pipfile to deploy successfully with the new version.

Since this would require coordination between the release and all pipenv users, or would result in a temporarily opt-in upgrade (which, if anyone missed the communications around it, could lead to quite a lot of frustration), we're not looking at this update any time soon.

@CaseyFaist CaseyFaist closed this Mar 27, 2020
@Mx-Glitter
Copy link

@CaseyFaist Can we revisit this when Pipenv gets its new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants