Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is related to #786
We're using Pipenv at my team but we've had problems with the version this buildpack pinned,
2018.5.18
. In the end we leveraged the compile hooks to install a different version, because this was a blocker and I didn't know a better way to do it... aside from upgrading the version upstream, which is what this PR is about.This upgrades Pipenv to
2018.11.26
, but also allows the variable to be overriden, similar to how it is done in other sections of the code.The only thing I'm still confused about is how to test the overriding part. I've read
test/run
a bit, and I think I can create a newtestOverridenPipenv
function that exports the variable, then unsets it after success. Will it be enough?