-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Hypercall interface in distinct crate #452
Conversation
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 64.04% 63.47% -0.57%
==========================================
Files 16 18 +2
Lines 2197 2204 +7
==========================================
- Hits 1407 1399 -8
- Misses 790 805 +15
|
d488734
to
82c4a1b
Compare
c02a699
to
47e0285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great initiative. 👍
Are clippy and doc CI run automatically for this workspace member?
Could you squash a few commits together?
Thank you for your nice and extensive review! I'll implement the changes, hopefully next week. :-) |
3541810
to
6fb2f26
Compare
5adf7fb
to
d807c98
Compare
…eric for non x86 architectures
This should enhance readability and allows reusing code in libhermit. Currently, the hypercall interface there is just copy-pasted.
Open points:
NETREAD
|NETSTAT
|NETWRITE
hypercalls.UART_PORT
as well.