Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rusty-demo workflow as it interferences with workspaces #457

Closed
wants to merge 1 commit into from

Conversation

jounathaen
Copy link
Member

Separated this from #452.

See the discussion here: #452 (comment)

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #457 (ef13e54) into master (7455ee8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files          16       16           
  Lines        2206     2206           
=======================================
  Hits         1400     1400           
  Misses        806      806           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkroening
Copy link
Member

Untouched run_images job

  • Runs pre-build images of Rust and C apps.
  • 👍 Fast (no image building necessary)
  • 👍 Easy to modify (just replace the images)
  • 👍 Stable (images don't change implicitly)
  • (👎) Little test (Currently runs only very simple hello world apps)
    • Easy to change!

Old rusty_demo job

  • Runs freshly built images of RustyHermit's repositories rusty_demo example.
  • 👎 Slow (image building necessary)
  • 👎 Hard to modify (sources are in external repo)
  • 🤷 Unstable (tracks latest hermit-sys git)
    • 👎 images change without changing the Uhyve repo
    • 👍 Detects failure before Uhyve and hermit-sys releases
      • Might not be Uhyve's task
  • 👍 Big test (Runs most complete demo test suite)

Proposed rusty_demo job

  • 👎 Slow (image building necessary)
  • 👎 Hard to modify (sources are in external repo)
  • 👎 Unstable (tracks latest rusty-demo git)
    • Runs already released hermit-sys
  • 👎 Small test (rusty-demo is only a most minimal example)

I propose that instead of changing the rusty_demo job in this way, we either leave it as is or remove it completely and instead use a more sophisticated image in the run_images job, depending on whether we want to test against hermit-sys git with Uhyve git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants