This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/kong] update services to route traffic only to app#9463
Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom Nov 26, 2018
Merged
[stable/kong] update services to route traffic only to app#9463k8s-ci-robot merged 1 commit intohelm:masterfrom
k8s-ci-robot merged 1 commit intohelm:masterfrom
Conversation
Since the labels are shared between Ingress controller and Kong Deployment, this can result in traffic being incorrectly sent to Ingress Controller pods as well. Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
Collaborator
Author
|
See #9020 (comment) |
Collaborator
Author
|
cc @joe1chen |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbagdi, shashiranjan84 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuchaoran2011
pushed a commit
to yuchaoran2011/charts
that referenced
this pull request
Nov 30, 2018
Since the labels are shared between Ingress controller and Kong Deployment, this can result in traffic being incorrectly sent to Ingress Controller pods as well. Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
davidkarlsen
pushed a commit
to davidkarlsen/charts
that referenced
this pull request
Dec 2, 2018
Since the labels are shared between Ingress controller and Kong Deployment, this can result in traffic being incorrectly sent to Ingress Controller pods as well. Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
yuchaoran2011
pushed a commit
to yuchaoran2011/charts
that referenced
this pull request
Dec 11, 2018
Since the labels are shared between Ingress controller and Kong Deployment, this can result in traffic being incorrectly sent to Ingress Controller pods as well. Signed-off-by: Harry Bagdi <harrybagdi@gmail.com> Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
Since the labels are shared between Ingress controller and Kong Deployment, this can result in traffic being incorrectly sent to Ingress Controller pods as well. Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the labels are shared between Ingress controller and Kong
Deployment, this can result in traffic being incorrectly sent to
Ingress Controller pods as well.
Signed-off-by: Harry Bagdi harrybagdi@gmail.com
What this PR does / why we need it:
Avoid sending traffic to Ingress controller pods due to incorrect selectors on the service.