[stable/kong] introduce Kong ingress controller

[hbagdi]

What this PR does / why we need it:

Deploy Kong as your Ingress controller!

This is developed by @merqurio and I'm merely making some doc changes and opening this PR.
#7350 is superseded by this.

[hbagdi]

/ok-to-test

[hbagdi]

/assign shashiranjan84

[hbagdi]

/test pull-charts-e2e

[hbagdi]

UPDATE: Please ignore this, this was due to a bad helm-hook of post-delete.

@unguiculus Testing locally, the crd-install hook seems to have a problem.

It doesn't actually install the CRD.

Running the following:

helm install --dry-run --debug . \
    --set ingressController.enabled=true \
    --namespace yolo \
    --set admin.useTLS=false \
    --set readinessProbe.httpGet.scheme=HTTP \
    --set livenessProbe.httpGet.scheme=HTTP

give the following output:
https://gist.github.com/hbagdi/fb9edd4c4657670cc12bbf77e141df5a

[hbagdi]

The tests should now pass once the CRDs are deleted manually once from the test infra cluster.
We're not using a hook for the chart since we don't use the any object of that CR type.

[hbagdi]

/retest

[hbagdi]

@unguiculus Really appreciate you jumping in on this one and helping out troubleshoot the CI issue. Could you review this once more?
Thank you!

[shashiranjan84]

/lgtm

[hbagdi]

@unguiculus Gentle ping for an approval on this PR.

[cpanato]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hbagdi, shashiranjan84

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• stable/kong/OWNERS [hbagdi,shashiranjan84]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[merqurio]

Thanks @hbagdi for this

[hbagdi]

@merqurio @cpanato @unguiculus @shashiranjan84 Thank you for helping get this through!

[joe1chen]

@hbagdi Great work on this! I've been following this issue and testing it the past few days.

I found a pretty severe bug with this pull though. It will break the kong proxy because a bug is introduced where traffic is occasionally sent to the ingress controller pod instead of the proxy pods. I kept on getting intermittent connection refused errors until I found the issue is a result of the services not having a specific enough selector.

In service-kong-admin.yaml:
Change:

  selector:
    app: {{ template "kong.name" . }}
    release: {{ .Release.Name }}

to

  selector:
    app: {{ template "kong.name" . }}
    release: {{ .Release.Name }}
    component: app

And the same in service-kong-proxy.yaml:
Change:

  selector:
    app: {{ template "kong.name" . }}
    release: {{ .Release.Name }}

to:

  selector:
    app: {{ template "kong.name" . }}
    release: {{ .Release.Name }}
    component: app

Normally I would fork and open a pull request, but the last time I tried to contribute to helm, I had issues getting my environment set up to sign the contributor agreement. So in the interests of time and because this is a severe bug, I'm hoping you can open the bug for me and fix it.

I also have a few other enhancements to contribute, such as support for TLS, which is working well with cert-manager and LetsEncrypt.