Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@timstoop
Copy link
Contributor

@timstoop timstoop commented Apr 6, 2018

What this PR does / why we need it:

As discussed in #2149, this Chart is not working for a very long time now and nobody seems to be picking up the slack. Therefore, I think it's warranted to deprecate this chart. I followed the steps outlined in PROCESSES.md at the root of the charts repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2018
@timstoop
Copy link
Contributor Author

timstoop commented Apr 6, 2018

/assign @linki
/assign @unguiculus

@timstoop
Copy link
Contributor Author

timstoop commented Apr 6, 2018

Of course, the CI fails...

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2018
@unguiculus
Copy link
Member

Was trying to push it directly but couldn't since master is now protected.

@unguiculus
Copy link
Member

/retest

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timstoop, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit cba5811 into helm:master Jul 30, 2018
marekaf pushed a commit to marekaf/charts that referenced this pull request Sep 4, 2018
* [stable/gcloud-endpoints] Deprecate chart

* Update Chart.yaml

Signed-off-by: Marek Bartik <[email protected]>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
* [stable/gcloud-endpoints] Deprecate chart

* Update Chart.yaml

Signed-off-by: aba182 <[email protected]>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
* [stable/gcloud-endpoints] Deprecate chart

* Update Chart.yaml

Signed-off-by: Jakob Niggel <[email protected]>
gsemet pushed a commit to gsemet/charts that referenced this pull request Nov 13, 2018
* [stable/gcloud-endpoints] Deprecate chart

* Update Chart.yaml

Signed-off-by: Gaetan Semet <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants