This repository was archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
[stable/gcloud-endpoints] Deprecating Chart. #4768
Merged
k8s-ci-robot
merged 3 commits into
helm:master
from
timstoop:deprecating-gcloud-endpoints
Jul 30, 2018
Merged
[stable/gcloud-endpoints] Deprecating Chart. #4768
k8s-ci-robot
merged 3 commits into
helm:master
from
timstoop:deprecating-gcloud-endpoints
Jul 30, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/assign @linki |
Contributor
Author
|
Of course, the CI fails... |
Member
|
Was trying to push it directly but couldn't since master is now protected. |
Member
|
/retest |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timstoop, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
marekaf
pushed a commit
to marekaf/charts
that referenced
this pull request
Sep 4, 2018
* [stable/gcloud-endpoints] Deprecate chart * Update Chart.yaml Signed-off-by: Marek Bartik <[email protected]>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* [stable/gcloud-endpoints] Deprecate chart * Update Chart.yaml Signed-off-by: aba182 <[email protected]>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* [stable/gcloud-endpoints] Deprecate chart * Update Chart.yaml Signed-off-by: Jakob Niggel <[email protected]>
gsemet
pushed a commit
to gsemet/charts
that referenced
this pull request
Nov 13, 2018
* [stable/gcloud-endpoints] Deprecate chart * Update Chart.yaml Signed-off-by: Gaetan Semet <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed in #2149, this Chart is not working for a very long time now and nobody seems to be picking up the slack. Therefore, I think it's warranted to deprecate this chart. I followed the steps outlined in PROCESSES.md at the root of the charts repository.