Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Conversation

@kevinschumacher
Copy link
Contributor

…t name
#1785

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2017
@dhilipkumars
Copy link
Contributor

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2017
@dhilipkumars
Copy link
Contributor

/test pull-charts-e2e

2 similar comments
@dhilipkumars
Copy link
Contributor

/test pull-charts-e2e

@kevinschumacher
Copy link
Contributor Author

/test pull-charts-e2e

@kevinschumacher
Copy link
Contributor Author

/retest

@kevinschumacher
Copy link
Contributor Author

@dhilipkumars the tests are failing because the .Values.image url is no longer valid. I have submitted a PR to fix that here: #2321

@dhilipkumars
Copy link
Contributor

cc: @ultimateboy could you suggest? The CI fails as the image seems to be invalid anymore.

@dhilipkumars
Copy link
Contributor

@kubernetes/charts-maintainers Im going to merge this inspite of failing test, the chart is resonably un- maintained.

@unguiculus
Copy link
Member

/retest

@unguiculus
Copy link
Member

No idea why this still fails.

@unguiculus
Copy link
Member

@ultimateboy Could you have a look at this?

@dhilipkumars
Copy link
Contributor

Should we just ignore this chart and move on ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevinschumacher
We suggest the following additional approver: seanknox

Assign the PR to them by writing /assign @seanknox in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mattfarina
Copy link
Contributor

Do we need to increase the build time?

/retest

@unguiculus
Copy link
Member

Increasing the timeout won't help. The pods don't come up.

I0116 16:04:27.748] gcloud--4730-gcloud-endp-d46c784cf-wvz2w   0/1       CrashLoopBackOff   6         9m

If @ultimateboy does not react, I'd deprecate the chart. The chart was alread broken which was revealed in this PR.

@timstoop
Copy link
Contributor

timstoop commented Apr 6, 2018

/retest
I'm going to assume nothing has really changed here, so if this test fails again, I'm going to start the process of deprecating the chart, as described in https://github.com/kubernetes/charts/blob/master/PROCESSES.md.

@k8s-ci-robot
Copy link
Contributor

@kevinschumacher: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e dab6b70 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2018
@stale
Copy link

stale bot commented Aug 8, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants