Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Fix the fullname refs overlooked in #2177 #2417

Merged
dhilipkumars merged 2 commits into from
Oct 11, 2017
Merged

Fix the fullname refs overlooked in #2177 #2417

dhilipkumars merged 2 commits into from
Oct 11, 2017

Conversation

@dae0eeWi
Copy link
Contributor

@dae0eeWi dae0eeWi commented Oct 5, 2017

No description provided.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 5, 2017

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 5, 2017

Hi @dae0eeWi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 10, 2017

@dae0eeWi Thanks for the PR, could you please sign the CLA? We could get this change in asap

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 10, 2017

cc: #2449

@dae0eeWi
Copy link
Contributor Author

dae0eeWi commented Oct 10, 2017

Ok CLA done

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 10, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 11, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 11, 2017

/assign

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 11, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2017
@dhilipkumars dhilipkumars merged commit 01d7f1e into helm:master Oct 11, 2017
packetcollision pushed a commit to Vungle/charts that referenced this pull request Oct 26, 2017
@dae0eeWi @packetcollision
Fix the fullname refs overlooked in helm#2177 (helm#2417)
de84ad6 
* fullname -> minio.fullname in post-install template

* bump patch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dae0eeWi @k8s-ci-robot @dhilipkumars