Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/minio] #1785 namespace defined templates with chart name #2177

Merged
dhilipkumars merged 1 commit into from
Oct 5, 2017
Merged

[stable/minio] #1785 namespace defined templates with chart name #2177

dhilipkumars merged 1 commit into from
Oct 5, 2017

Conversation

@kevinschumacher
Copy link
Contributor

@kevinschumacher kevinschumacher commented Sep 17, 2017

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2017

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2017
@kevinschumacher kevinschumacher mentioned this pull request Sep 17, 2017
Closed
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 4, 2017

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 4, 2017
@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 5, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2017
@dhilipkumars dhilipkumars merged commit 66ce5f5 into helm:master Oct 5, 2017
@hypnoglow
Copy link
Contributor

hypnoglow commented Oct 6, 2017 •
edited
Loading

minio chart is broken now:
https://github.com/kubernetes/charts/blob/master/stable/minio/templates/post-install-create-bucket-pod.yaml#L5
The hook is still using "template fullname".

@dhilipkumars
Copy link
Contributor

dhilipkumars commented Oct 10, 2017

@kevinschumacher could you PTAL?

@dhilipkumars dhilipkumars mentioned this pull request Oct 10, 2017
Closed
dhilipkumars pushed a commit that referenced this pull request Oct 11, 2017
@dae0eeWi
Fix the fullname refs overlooked in #2177 (#2417)
01d7f1e 
* fullname -> minio.fullname in post-install template

* bump patch
packetcollision pushed a commit to Vungle/charts that referenced this pull request Oct 26, 2017
@dae0eeWi @packetcollision
Fix the fullname refs overlooked in helm#2177 (helm#2417)
de84ad6 
* fullname -> minio.fullname in post-install template

* bump patch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinschumacher @k8s-ci-robot @dhilipkumars @hypnoglow