Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions stable/openvpn/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
apiVersion: v1
description: A Helm chart to install an openvpn server inside a kubernetes cluster. Certificate generation is also part of the deployment, and this chart will generate client keys as needed.
description: A Helm chart to install an openvpn server inside a kubernetes cluster. Certificate
generation is also part of the deployment, and this chart will generate client keys
as needed.
name: openvpn
version: 1.1.2
version: 2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update only the minor version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is a breaking change to the chart's API.

A previous discussion on a similar PR for stable/acs-engine-autoscaler

If this is a breaking API change, then I think we should be bumping the major version.

maintainers:
- name: John Felten
email: [email protected]
- name: John Felten
email: [email protected]
icon: https://forums.openvpn.net/styles/openvpn/theme/images/ovpnlogo.png
keywords:
- openvpn
- vpn
- tunnel
- network
- service
- connectivity
- encryption
- openvpn
- vpn
- tunnel
- network
- service
- connectivity
- encryption
home: https://openvpn.net/index.php/open-source.html
sources:
- https://github.com/jfelten/openvpn-docker
- https://github.com/kubernetes/charts/tree/master/stable/openvpn
- https://github.com/jfelten/helm-charts

- https://github.com/jfelten/openvpn-docker
- https://github.com/kubernetes/charts/tree/master/stable/openvpn
- https://github.com/jfelten/helm-charts
4 changes: 2 additions & 2 deletions stable/openvpn/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
{{/*
Expand the name of the chart.
*/}}
{{- define "name" -}}
{{- define "openvpn.name" -}}
{{- default .Chart.Name .Values.nameOverride | trunc 24 -}}
{{- end -}}

{{/*
Create a default fully qualified app name.
Truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
*/}}
{{- define "fullname" -}}
{{- define "openvpn.fullname" -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- printf "%s-%s" .Release.Name $name | trunc 24 -}}
{{- end -}}
4 changes: 2 additions & 2 deletions stable/openvpn/templates/certs-pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: {{ template "fullname" . }}
name: {{ template "openvpn.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
app: {{ template "fullname" . }}
app: {{ template "openvpn.fullname" . }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
Expand Down
2 changes: 1 addition & 1 deletion stable/openvpn/templates/config-openvpn.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ template "fullname" . }}
name: {{ template "openvpn.fullname" . }}
namespace: {{ .Release.Namespace }}
data:
setup-certs.sh: |-
Expand Down
8 changes: 4 additions & 4 deletions stable/openvpn/templates/openvpn-deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
name: {{ template "fullname" . }}
name: {{ template "openvpn.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
heritage: {{ .Release.Service | quote }}
Expand All @@ -13,7 +13,7 @@ spec:
template:
metadata:
labels:
app: {{ template "fullname" . }}
app: {{ template "openvpn.fullname" . }}
type: openvpn
heritage: {{ .Release.Service | quote }}
release: {{ .Release.Name | quote }}
Expand Down Expand Up @@ -48,12 +48,12 @@ spec:
volumes:
- name: openvpn
configMap:
name: {{ template "fullname" . }}
name: {{ template "openvpn.fullname" . }}
defaultMode: 0775
- name: certs
{{- if .Values.persistence.enabled }}
persistentVolumeClaim:
claimName: {{ template "fullname" . }}
claimName: {{ template "openvpn.fullname" . }}
{{- else }}
emptyDir: {}
{{- end -}}
4 changes: 2 additions & 2 deletions stable/openvpn/templates/openvpn-service.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
kind: Service
apiVersion: v1
metadata:
name: {{ template "fullname" . }}
name: {{ template "openvpn.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
Expand All @@ -13,5 +13,5 @@ spec:
targetPort: {{ .Values.service.internalPort }}
protocol: {{ .Values.openvpn.OVPN_PROTO | upper }}
selector:
app: {{ template "fullname" . }}
app: {{ template "openvpn.fullname" . }}
type: {{ .Values.service.type }}