[stable/openvpn] #1785 namespace defined templates with chart name

[kevinschumacher]

#1785

[k8s-ci-robot]

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dhilipkumars]

/ok-to-test
/assign

[dhilipkumars]

Please update only the minor version

[kevinschumacher]

IMO this is a breaking change to the chart's API.

A previous discussion on a similar PR for stable/acs-engine-autoscaler

If this is a breaking API change, then I think we should be bumping the major version.

[mattfarina]

/cc @jfelten

[k8s-ci-robot]

@mattfarina: GitHub didn't allow me to request PR reviews from the following users: jfelten.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @jfelten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jfelten]

@kevinschumacher can you explain why you think this is a change to the chart's api? I read #1785, but don't quite see it. Are you referring to other charts that use openvpn as a subchart and reference the templates?

[mattfarina]

@jfelten I think the sub-chart case is what is meant. If someone uses openvpn as a sub-chart and their values files need to change in any way that breaks backwards compatibility it's an API breaking change. In SemVer that's a major version bump.

[jfelten]

Thanks @mattfarina - I agree that anything breaking downstream dependencies = api change, so the version bump is justified.

[dhilipkumars]

/lgtm
/approve