[stable/acs-engine-autoscaler] #1785 namespace defined templates with…

[kevinschumacher]

… chart name

#1785

[k8s-ci-robot]

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kevinschumacher]

@dhilipkumars note that I have incremented the major version here.

[mgoodness]

Does this really need to be a major version change? Doesn't seem to be breaking.

[kevinschumacher]

IMO we are changing the chart's API in a breaking way by changing the names of defined template functions.

Example:
subchart1 defines fullname
parent, which depends on subchart1, uses the fullname template function (it's global) in a configmap (or other resource) like {{ template "fullname" . }}

subchart1, in a minor version release, has the global defined template names changed from fullname to subchart1.fullname.

author of parent updates dependency, tries to deploy, and parent's configmap won't render because there is no longer a template function fullname (it's now subchart1.fullname)

[mgoodness]

/ok-to-test

[mgoodness]

/lgtm