Add new flags to disable lint/schema validation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @unguiculus |
unguiculus
requested changes
Dec 18, 2018
pkg/chart/chart.go
Outdated
| result.Error = err | ||
| return result | ||
|
|
||
| if !t.config.NoYamlLint { |
There was a problem hiding this comment.
Reflecting about this again, I'm think it would be better to do it the other way around and call the flags validate-yaml and validate-chart-schema. This would also be more consistent with the existing flags.
There was a problem hiding this comment.
sure, was hard to me to think in the negative 😄 i will update
thanks for the review @unguiculus
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Signed-off-by: Reinhard Nägele <[email protected]>
unguiculus
approved these changes
Dec 19, 2018
|
I added some minor updates if you don't mind. |
|
@unguiculus no problem from my side. thanks btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add new flags to by pass lint/schema validation:
no-chart-schema-validationandno-yaml-lintWhich issue this PR fixes