Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit dependence on extra tools/repos #53

Closed
munnerz opened this issue Nov 14, 2018 · 3 comments · Fixed by #68
Closed

Remove implicit dependence on extra tools/repos #53

munnerz opened this issue Nov 14, 2018 · 3 comments · Fixed by #68
Assignees

Comments

@munnerz
Copy link

munnerz commented Nov 14, 2018

Hey all 👋

First of all, thanks very much for this project. We use the old bash version of this in cert-manager and it works well 😄

The recent Go rewrite is great, and I'm keen to get this setup in our own environment again.

I wonder if there is any desire to remove the dependence on yamale/yamllint?

We're hoping to be able to run this without the need for Docker, so for the time being will need to configure our own build/test environment to grab the appropriate version of these tools.

Can these projects either be included in the Go binary release somehow, or otherwise can their functionality be absorbed into Go?

@unguiculus
Copy link
Member

Hey @munnerz, great to hear you use it. 😄

I'm not aware of any alternatives in Go that could replace these tools. However, I guess we could add flags for disabling them.

@unguiculus unguiculus self-assigned this Dec 10, 2018
@cpanato
Copy link
Member

cpanato commented Dec 12, 2018

The flags will be set up in the CT_XXXX env flags?
I would like to try out this one. @unguiculus can we define the scope?

thanks

@unguiculus
Copy link
Member

@cpanato You just flags in lint.go. The user is then free to choose whether they want to use the cli flag, an env var, or a config file to configure it.

I would add two flags:

  • no-chart-schema-validation
  • no-yaml-lint

What do you think?
@munnerz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants