add --extra-helm-args to ct lint

[AndersBennedsgaard]

What this PR does / why we need it:

Makes it possible to pass extra Helm arguments to ct lint, such as --strict.

Which issue this PR fixes

Does not strictly fix, but helps with #166

[cpanato]

@AndersBennedsgaard can you please rebase? thanks for this PR

[cpanato]

and need to generate the docs.

[AndersBennedsgaard]

I completely forgot all about this PR. I have synced the two repos :)

and need to generate the docs.

Is there a way to auto-generate/-update docs (doc/ct_lint.md I guess?), or do I have to manually do this?

[cpanato]

I completely forgot all about this PR. I have synced the two repos :)

and need to generate the docs.

Is there a way to auto-generate/-update docs (doc/ct_lint.md I guess?), or do I have to manually do this?

          go build -o ct-bin ./ct/main.go
          ./ct-bin doc-gen

also please do a rebase and remove the unnecessary commits, thanks

[AndersBennedsgaard]

@cpanato does it look correct now? (I had some issues with rebasing, since I never use it)

[cpanato]

thanks

[hypery2k]

having the same issues within gitlab:

$ git status
HEAD detached at b817f07
nothing to commit, working tree clean
$ git branch
* (HEAD detached at b817f07)
$ git fetch origin
$ ct lint --config charttesting-conf.yaml
Linting charts...
>>> helm version --template {{ .Version }}
>>> git rev-parse --is-inside-work-tree
>>> git rev-parse --verify main
------------------------------------------------------------------------------------------------------------------------
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------
failed linting charts: failed identifying charts to process: targetBranch 'main' does not exist
Error: failed linting charts: failed identifying charts to process: targetBranch 'main' does not exist
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: exit code 1

With v3.8.0 it works:

$ git status
HEAD detached at d05b9db
nothing to commit, working tree clean
$ git branch
* (HEAD detached at d05b9db)
$ git fetch origin
$ ct lint --config charttesting-conf.yaml
Linting charts...
>>> helm version --template {{ .Version }}
>>> git rev-parse --is-inside-work-tree
>>> git merge-base origin/main HEAD
>>> git diff --find-renames --name-only 43bcf6ea0e66b[26]...
------------------------------------------------------------------------------------------------------------------------
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully
Cleaning up project directory and file based variables
00:01
Job succeeded

Can reproduce it within multiple gitlab installations.