Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): pin chart testing to v3.8.0 #515

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jul 24, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:

The latest version of chart testing adds support for extra args when running helm linting. The timeout flag used for the install command is incompatible with the lint command. We just revert to the prior version until the issue is solved.

See: helm/chart-testing#552
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

The latest version of chart testing adds support for extra args
when running helm linting. The timeout flag used for the install
command is incompatible with the lint command. We just revert
to the prior version until the issue is solved.

Signed-off-by: Aldo Lacuku <[email protected]>
@poiana
Copy link
Contributor

poiana commented Jul 24, 2023

@alacuku: The label(s) area/event-generator-chart cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:

The latest version of chart testing adds support for extra args when running helm linting. The timeout flag used for the install command is incompatible with the lint command. We just revert to the prior version until the issue is solved.

See: helm/chart-testing#552
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

No changes made to the falco chart, but the current CI requires
that the chart version is bumped each time a file is modified

Signed-off-by: Aldo Lacuku <[email protected]>
@poiana poiana added size/S and removed size/XS labels Jul 25, 2023
@poiana
Copy link
Contributor

poiana commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jul 25, 2023

LGTM label has been added.

Git tree hash: 6c3d0bf09161364772f3cf534b1b1f5b5faa9b51

@poiana poiana merged commit 7614ec3 into falcosecurity:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants