-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Breaking change) chore: change default target-branch to main #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fty4 can you rebase and update the docs? thanks for this PR |
closes #376 Signed-off-by: Marco Lecheler <[email protected]> Signed-off-by: Marco Lecheler <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]> Signed-off-by: Marco Lecheler <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]> Signed-off-by: Marco Lecheler <[email protected]>
@cpanato I've updated the docs and forced-pushed the rebased commits. |
this will be a breaking change for existing users, if they dont set the --target-branch in the config |
That is true - I already mentioned this in the PR body. New users will still have to specify the parameter if this will not be changed. |
when we release I will make a note in the release notes for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small request
Co-authored-by: Carlos Tadeu Panato Junior <[email protected]> Signed-off-by: Marco Lecheler <[email protected]>
LGTM 👍 |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Lgtm. We can maybe bump version number a bit to signal breaking change. |
yes |
let marinate this in the main branch for a while |
What this PR does / why we need it:
Because the default branch on GitHub is
main
and not longermaster
this should also be the default to chart-testing.Which issue this PR fixes:
fixes #376
Special notes for your reviewer:
BREAKING CHANGE:
If e.g an action or workflow is not using an explicit specified
target-branch
the job might will fail after this change.But after this change new users does not have the problem that a wrong branch is used.
For example I was suffering with the error message
exit status 128
- see #330 because the default branch was notmain
.