Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] target-branch default should fallback to main from master (or visa versa) #376

Closed
spkane opened this issue Jan 7, 2022 · 2 comments · Fixed by #510
Closed
Labels

Comments

@spkane
Copy link

spkane commented Jan 7, 2022

Is this a request for help?: No


Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Version of Helm and Kubernetes:

version.BuildInfo{Version:"v3.7.2", GitCommit:"663a896f4a815053445eec4153677ddc24a0a361", GitTreeState:"clean", GoVersion:"go1.17.3"}

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:33:37Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:42:41Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"}

Version: 3.5.0
Git commit: e97261b
Date: 2022-01-06
License: Apache 2.0

What happened:

$ ct list-changed
Error: Error running process: exit status 128
Error running process: exit status 128

What you expected to happen:

I expected it to work, or provide a useful error message.

How to reproduce it (as minimally and precisely as possible):

Create a new git repo that uses main instead of master as its default branch, and has no master branch.
Commit a helm chart into the main branch
Create a branch and modify the helm chart and then commit it to your branch.

Run:

$ ct list-changed
Error: Error running process: exit status 128
Error running process: exit status 128

Anything else we need to know:

A descriptive error message would be a big improvement, but it would also be nice if the tool actually used main as the default target branch, and if it gets an error finding that branch, it falls back to trying master before finally giving the user an error that "the default branch (main or master) can not be found. Please provide the correct target-branch with --target-branch"

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 11, 2023
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
cpanato added a commit that referenced this issue Nov 19, 2023
* chore: change default target-branch to main

closes #376

Signed-off-by: Marco Lecheler <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]>

* docs: change default target-branch to main

Signed-off-by: Marco Lecheler <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]>

* docs: update missing inclusive naming

Signed-off-by: Marco Lecheler <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]>

* chore: update kind readme to use inclusive naming

Co-authored-by: Carlos Tadeu Panato Junior <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]>

---------

Signed-off-by: Marco Lecheler <[email protected]>
Signed-off-by: Marco Lecheler <[email protected]>
Co-authored-by: Carlos Tadeu Panato Junior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant