Introduce helm-extra-set-args command line parameter #402
+54
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmax
changed the title
ilmax
force-pushed
the
ilmax/add-helm-extra-set-flag
branch
2 times, most recently
from
431c57f to
2201116
Compare
|
@ilmax thanks for the PR, there are some updates in the tests you need to adjust and also can you add some tests for this change as well? |
ilmax
force-pushed
the
ilmax/add-helm-extra-set-flag
branch
from
58d2a73 to
3d30428
Compare
added 2 commits
March 15, 2022 16:10
Signed-off-by: ilmax <[email protected]> Signed-off-by: Massimiliano Donini <[email protected]>
- Fixed error when no values are passed in - Added integration test Signed-off-by: Massimiliano Donini <[email protected]>
ilmax
force-pushed
the
ilmax/add-helm-extra-set-flag
branch
from
3d30428 to
feb4b66
Compare
|
@cpanato I fixed the issue, and added an integration test where I fetch another version of nginx, let me know if you need me to do something more here, Thanks! |
|
@ilmax thanks for the PR then commit the changes? |
Signed-off-by: Massimiliano Donini <[email protected]>
|
@cpanato Sorry, I missed that, done and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Often times it's required to override the values file when running chart-testing, we have
helm-extra-argscommand line option, but that one is used also to uninstall the release so adding set parameters there results in an error in uninstalling the release (see #322, #212, #171)Which issue this PR fixes
fixes #322, fixes #212, fixes #171
Special notes for your reviewer: