extraArgs removed from uninstall command

[ahmetkaftan]

Signed-off-by: Ahmet Kaftan [email protected]

What this PR does / why we need it:
When removing chart after chart install, helm uninstall command gets the extraArgs which has been added with --helm-extra-args flag.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #212

Special notes for your reviewer:

[alespour]

@tylerauerbeck This would be nice to have merged. Thank you for your consideration.

[tylerauerbeck]

@alespour Thanks for the ping. This seems fairly harmless and seems to work to me. But, I don't have any approver/merge power here. So we'll probably want @cpanato or @scottrigby to take a look.

[smlx]

So with this PR how do I pass an extra argument to the helm uninstall command?

[ahmetkaftan]

So with this PR how do I pass an extra argument to the helm uninstall command?

I don't think it's necessary to pass extra arguments when running helm uninstall command.

[smlx]

I don't think it's necessary to pass extra arguments when running helm uninstall command.

I disagree. There are plenty of global options which might be useful being passed to uninstall. In addition this is a breaking change. A better solution to #212 is in a comment on that issue: #212 (comment)

[ahmetkaftan]

fixed with #402