chart_schema.yaml - dependency.repository should not be required #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unguiculus @cpanato Can this be merged? By having the repository field as mandatory, subcharts developed locally cannot be tested. Related #324 |
cpanato
requested changes
Mar 12, 2021
when using a local chart there is no repository so this should be optional field. Signed-off-by: Ian Tewksbury <[email protected]>
|
@cpanato done. |
unguiculus
approved these changes
Mar 12, 2021
cpanato
approved these changes
Mar 12, 2021
|
@cpanato thank you |
|
Any ETA on when this'll be part of a release? I assume v3.3.2 will include this? |
|
I will take a look next week |
ubergesundheit
added a commit
to giantswarm/app-build-suite
that referenced
this pull request
Mar 25, 2021
…dependencies Update our derived chart-testing schema ahead of an actual chart-testing release. Upstream PR: helm/chart-testing#300
ubergesundheit
added a commit
to giantswarm/app-build-suite
that referenced
this pull request
Mar 25, 2021
…dependencies (#83) * Update chart-testing schema to not require repository field in chart dependencies Update our derived chart-testing schema ahead of an actual chart-testing release. Upstream PR: helm/chart-testing#300 * patch original chart_schema yaml with upstream changes
|
Any update on the release? Our subchart testing jobs have been failing due to this. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes the depednecy.*.repository field optional because when using a local chart there is no repository.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: