Lnd refactor #3
Merged
Lnd refactor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9584ab.
|
Merging this with failing status due to bug in the chart-testing tool |
| @@ -0,0 +1,22 @@ | |||
| 1. Get the application URL by running these commands: | |||
There was a problem hiding this comment.
I think this should be expended:
how to get the TLS, macaroon, execute a lncli on the pod, etc.
| @@ -0,0 +1,28 @@ | |||
| {{- if .Values.autoscaling.enabled }} | |||
There was a problem hiding this comment.
(ie: not compatible with lnd)
| labels: | ||
| {{- include "lnd.labels" . | nindent 4 }} | ||
| stringData: | ||
| password: {{ default "randAlphaNum 6" .Values.walletPassword | quote }} |
There was a problem hiding this comment.
there should be a lot more characters because 6 can easily be brute force. 24 at least.
Will address in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.