Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker image versions #253

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Bump docker image versions #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69099bb
Bump docker image versions
smlx Aug 5, 2020
570ae63
Update Dockerfile
unguiculus Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
FROM alpine:3.11
FROM alpine:3.12

RUN apk --no-cache add \
curl \
git \
libc6-compat \
openssh-client \
python \
py-crcmod \
py-pip && \
pip install --upgrade pip==18.1
py3-pip \
py3-wheel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Python expert. Why would we want py3-wheel? The image builds fine without it.

Copy link
Contributor Author

@smlx smlx Aug 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to install wheel is to avoid a series of warnings like this that you'll see if you run pip and don't have wheel installed:

Using legacy 'setup.py install' for pyyaml, since package 'wheel' is not installed.

For what wheels are and why they're better than setup.py, there's a reasonable overview here.

python3 && \
pip install --upgrade pip==20.2.1

# Install a YAML Linter
ARG yamllint_version=1.21.0
ARG yamllint_version=1.24.2
LABEL yamllint_version=$yamllint_version
RUN pip install "yamllint==$yamllint_version"

# Install Yamale YAML schema validator
ARG yamale_version=2.0.1
ARG yamale_version=3.0.2
LABEL yamale_version=$yamale_version
RUN pip install "yamale==$yamale_version"

Expand Down