Bump docker image versions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* alpine 3.12 * python 3 * yamale 3.0.2 * yamllint 1.24.2 Signed-off-by: Scott Leggett <[email protected]>
unguiculus
reviewed
Aug 9, 2020
| py-pip && \ | ||
| pip install --upgrade pip==18.1 | ||
| py3-pip \ | ||
| py3-wheel \ |
There was a problem hiding this comment.
I'm not a Python expert. Why would we want py3-wheel? The image builds fine without it.
There was a problem hiding this comment.
The reason to install wheel is to avoid a series of warnings like this that you'll see if you run pip and don't have wheel installed:
Using legacy 'setup.py install' for pyyaml, since package 'wheel' is not installed.
For what wheels are and why they're better than setup.py, there's a reasonable overview here.
Signed-off-by: Reinhard Nägele <[email protected]>
unguiculus
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR bumps the version of the base image, and the tools within it, to their latest versions.
Which issue this PR fixes: supersedes #234
Special notes for your reviewer: I notice that #234 has a request for extra testing, so I've built an image that contains #250, #251, and this PR. It's available here. I've also tested this image here in the chart-testing lint action.