Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider username and password in repo urls #162

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Consider username and password in repo urls #162

merged 1 commit into from
Jul 9, 2019

Conversation

unguiculus
Copy link
Member

Fixes: #156

@unguiculus unguiculus requested review from jlegrone and scottrigby July 6, 2019 17:18
scottrigby
scottrigby approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@unguiculus unguiculus merged commit e731d94 into helm:master Jul 9, 2019
@unguiculus unguiculus deleted the gitlab branch July 9, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlegrone jlegrone jlegrone approved these changes

@scottrigby scottrigby scottrigby approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate maintainers in GitLab runners
4 participants
@unguiculus @scottrigby @jlegrone @helm-bot