Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate maintainers in GitLab runners #156

Closed
alvgarvilla opened this issue May 16, 2019 · 1 comment · Fixed by #162
Closed

Validate maintainers in GitLab runners #156

alvgarvilla opened this issue May 16, 2019 · 1 comment · Fixed by #162
Assignees

Comments

@alvgarvilla
Copy link

BUG REPORT

Version of Helm and Kubernetes:
Helm v2.12.3
Kubernetes v1.11.7

What happened:

For validating the maintainers it sends a HEAD request to the URL built like: repoUrl/maintainerName.

repoUrl is obtained through the following command:

git ls-remote --get-url origin

In most of the cases, if you run it the output for GitLab would be something like:

https://gitlab.com/my-nice-group/MyNiceProject.git

Which matches perfectly with the regex expression defined in https://github.com/helm/chart-testing/blob/master/pkg/tool/account.go#L27

But if you run that command in a GitLab runner, the output would be:

https://gitlab-ci-token:[MASKED]@gitlab.com/my-nice-group/MyNiceProject.git

So the validation will always fail with the following error:

Error validating maintainers: Head https://gitlab-ci-token/garcal01: dial tcp: lookup gitlab-ci-token on 192.168.0.10:53: server misbehaving

What you expected to happen:
regex expression also matches GitLab runner output

How to reproduce it (as minimally and precisely as possible):
Use helm/chart-testing tool in a GitLab runner validating maintainers

@unguiculus
Copy link
Member

Thanks for reporting this. Would you mind submitting a PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants