CheckVersionIncrement is always fasle

[monotek]

Is this a request for help?:

No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
Helm 2.12
Kubectl 1.12
ct 2.0.1

What happened:
Were using a CircleCi pipeline (https://github.com/zammad/helm/blob/master/.circleci/config.yml) mainly based on the example from this repo.

When the chart is linted it does not fail when the chart version is not raised. See: https://circleci.com/gh/zammad/helm/150

CheckVersionIncrement is set to false even if it should be true by default.
Also the explicit setting of "check-version-increment: true" in ct.yaml is ignored.

What you expected to happen:

• linting fails if version is not raised.

How to reproduce it (as minimally and precisely as possible):
Use config from: https://github.com/zammad/helm/blob/master/.circleci

[monotek]

OK, seems this is the cause: #56

Imho its still a problem that setting "check-version-increment: true" explicitly is ignored.

At least an error message like "parameters can't be used together" would be nice.

[monotek]

I guess if i put the chart into a subdirectory (charts )it would work.
Is this wanted behaviour?

Edit: #73 may fix my problem too :-)

[unguiculus]

I don't think #53 is your problem. If you want to lint all charts no matter if they changed or not, it makes sense to have the version check disabled. But #73 could indeed fix the issue. Please try again. v2.1.0 was just released.

[monotek]

Unfortunately the new version did not help. The chart is still linted.

I want to lint a single chart in the top directory of my repo. See: https://github.com/zammad/helm

If i update the for example the circle ci config in my repo currently, the pipeline starts, the chart is rebuild with the last already existing version, pushed to the helm repo and overwrites the original chart create time in the index.yaml.

What i like to see to happen is, that the pipeline fails because there is no chart version update and therefore nothing is pushed. I have a workaround for this in another repo with multiple charts: https://github.com/kiwigrid/helm-charts/blob/master/.circleci/lint-charts.sh

But i cant use this in zammad repo because the version check does not work.

A workaround to get at least the version check working would likly be to put my zammad directory in a subdir like "charts" but this looks kind of ugly in a single chart repo.

[unguiculus]

You should not set the --charts flag, which causes this. Also, --chart-dirs should point to the repo root in your case. Try this config:

helm-extra-args: --timeout 3600
chart-dirs: "."

[monotek]

Oh, this seems to work now.
I've seen errors like ". can't be found" before in the install step.
Can't reproduce now. Closing...