Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message shown for goto references #9382

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Fix error message shown for goto references #9382

merged 3 commits into from
Jan 25, 2024

Commits on Jan 19, 2024

  1. Fix error message shown for goto references 

    When a symbol with no references is <kbd>g</kbd><kbd>r</kbd>'d on, the
message shown is `No definition found.` Make it `No references found.`

Achieves this by introducing empty container checks at call sites
rendering one of the patterns redundant. Another possible solution is to
pass the error message as another argument.
    @theteachr
    theteachr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    59dea5a View commit details
    Browse the repository at this point in the history

  2. Use if-else over match

    @theteachr
    theteachr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    7803fcf View commit details
    Browse the repository at this point in the history

  3. Document the precondition for goto_impl

    @theteachr
    theteachr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e6ba429 View commit details
    Browse the repository at this point in the history