Fix error message shown for goto references #9382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a symbol with no references is <kbd>g</kbd><kbd>r</kbd>'d on, the message shown is `No definition found.` Make it `No references found.` Achieves this by introducing empty container checks at call sites rendering one of the patterns redundant. Another possible solution is to pass the error message as another argument.
the-mikedavis
added
S-waiting-on-author
the-mikedavis
added
S-waiting-on-review
flinesse
pushed a commit
to flinesse/helix
that referenced
this pull request
Jan 25, 2024
flinesse
pushed a commit
to flinesse/helix
that referenced
this pull request
Jan 25, 2024
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a symbol with no references is gr'd on, the message shown is
No definition found.Make itNo references found.Achieves this by introducing empty container checks at call sites rendering one of the patterns redundant. Another possible solution is to pass the error message as another argument.