Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): implement show document request #8865

Merged
merged 5 commits into from
Jan 17, 2024
Merged

feat(lsp): implement show document request #8865

merged 5 commits into from
Jan 17, 2024

Commits on Jan 8, 2024

  1. feat(lsp): implement show document request 

    Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument)
LSP server-sent request.

This PR builds on top of helix-editor#5820,
moves the external-URL opening functionality into shared crate-level
function that returns a callback that is now used by both the
`open_file` command as well as the window.showDocument handler if
the URL is marked as external.
    @matoous
    matoous committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3d5201e View commit details
    Browse the repository at this point in the history

  2. add return

    @matoous
    matoous committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7633b26 View commit details
    Browse the repository at this point in the history

  3. use vertical split

    @matoous
    matoous committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ab2e872 View commit details
    Browse the repository at this point in the history

  4. refactor

    @matoous
    matoous committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f7cd43c View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Merge branch 'master' into md/lsp-show-document

    @the-mikedavis
    the-mikedavis committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7ccc16c View commit details
    Browse the repository at this point in the history