feat(lsp): implement show document request #8865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matoous
commented
Nov 19, 2023
the-mikedavis
added
A-language-server
matoous
force-pushed
the
md/lsp-show-document
branch
2 times, most recently
from
ccfda22
to
464a64a
Compare
pascalkuthe
reviewed
Nov 21, 2023
pascalkuthe
reviewed
Nov 23, 2023
kirawi
added
S-waiting-on-author
matoous
force-pushed
the
md/lsp-show-document
branch
2 times, most recently
from
5a86376
to
113700e
Compare
the-mikedavis
added
S-waiting-on-review
matoous
force-pushed
the
md/lsp-show-document
branch
from
113700e
to
bc5e1e4
Compare
pascalkuthe
previously approved these changes
Jan 8, 2024
matoous
force-pushed
the
md/lsp-show-document
branch
from
bc5e1e4
to
efe56ee
Compare
Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument) LSP server-sent request. This PR builds on top of helix-editor#5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the `open_file` command as well as the window.showDocument handler if the URL is marked as external.
matoous
force-pushed
the
md/lsp-show-document
branch
from
efe56ee
to
f7cd43c
Compare
pascalkuthe
previously approved these changes
Jan 8, 2024
the-mikedavis
approved these changes
Jan 17, 2024
pascalkuthe
approved these changes
Jan 17, 2024
|
@matoous Thanks for your great work! Does this unlock any features in any particular language server? For example, the ability to jump to documentation when we get a lint error? Cheers! |
|
@David-Else I honestly haven't check the support from various LSPs. Some references I found:
I don't think the adoption is wide. |
|
@David-Else It unlocked this for me (typst live preview with "inverse search") typst-lsp-test.webmwhich I find pretty cool, thanks @matoous for the implementation in helix! What you're seeing here is typst-lsp with some experimental patches for live preview on top. |
hamrik
pushed a commit
to hamrik/helix
that referenced
this pull request
Jan 27, 2024
* feat(lsp): implement show document request Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument) LSP server-sent request. This PR builds on top of helix-editor#5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the `open_file` command as well as the window.showDocument handler if the URL is marked as external. * add return * use vertical split * refactor --------- Co-authored-by: Michael Davis <[email protected]>
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* feat(lsp): implement show document request Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument) LSP server-sent request. This PR builds on top of helix-editor#5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the `open_file` command as well as the window.showDocument handler if the URL is marked as external. * add return * use vertical split * refactor --------- Co-authored-by: Michael Davis <[email protected]>
|
Thanks for the inspiration @tmistele, I've suggested enabling something similar in texlab and the devs have been super responsive (see texlab 5.16.0 released today). So Latex inverse search now works in Helix :) |
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* feat(lsp): implement show document request Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument) LSP server-sent request. This PR builds on top of helix-editor#5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the `open_file` command as well as the window.showDocument handler if the URL is marked as external. * add return * use vertical split * refactor --------- Co-authored-by: Michael Davis <[email protected]>
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* feat(lsp): implement show document request Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument) LSP server-sent request. This PR builds on top of helix-editor#5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the `open_file` command as well as the window.showDocument handler if the URL is marked as external. * add return * use vertical split * refactor --------- Co-authored-by: Michael Davis <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* feat(lsp): implement show document request Implement [window.showDocument](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument) LSP server-sent request. This PR builds on top of helix-editor#5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the `open_file` command as well as the window.showDocument handler if the URL is marked as external. * add return * use vertical split * refactor --------- Co-authored-by: Michael Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement window.showDocument LSP server-sent request.
This PR builds on top of #5820, moves the external-URL opening functionality into shared crate-level function that returns a callback that is now used by both the
open_filecommand as well as thewindow.showDocumenthandler if the URL is marked as external.Requires