Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Agda #8285

Merged
merged 10 commits into from
Dec 16, 2023
Merged

Add support for Agda #8285

merged 10 commits into from
Dec 16, 2023

Conversation

omentic
Copy link
Contributor

@omentic omentic commented Sep 14, 2023

supersedes #3092

todo:

@omentic omentic marked this pull request as draft September 14, 2023 20:28
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Sep 14, 2023
@omentic omentic mentioned this pull request Sep 17, 2023
@omentic
Copy link
Contributor Author

omentic commented Sep 17, 2023

Syntax highlighting just about working. Trying to get functions working, then I think this'll be ready to merge.

The language server does not appear to work at all, unfortunately. I might remove it or leave it in with a note.

image

@omentic omentic marked this pull request as ready for review September 17, 2023 23:04
@omentic
Copy link
Contributor Author

omentic commented Sep 17, 2023

This PR is ready for review. I may have a follow-up sometime adding proper function highlighting & als support, the former appears to be a legitimate upstream bug and the latter still a mystery.

@the-mikedavis can you squash merge this or would you prefer me to rebase?

the-mikedavis
the-mikedavis previously approved these changes Sep 18, 2023
@the-mikedavis
Copy link
Member

We can squash + merge this, no need to rebase

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2023
@the-mikedavis the-mikedavis changed the title agda language support (wip) Add support for Agda Sep 18, 2023
the-mikedavis
the-mikedavis previously approved these changes Sep 20, 2023
@Septias
Copy link

Septias commented Dec 12, 2023

Is this stalling?

@omentic
Copy link
Contributor Author

omentic commented Dec 12, 2023

It's done on my end, I've been running it locally for a while. The syntax highlighting is unfortunately pretty terrible - but it's nothing that can be addressed until tree-sitter/tree-sitter#880 is addressed. Any more specificity with regard to types kills performance exponentially (> 3 ish is unusable) and breaks highlighting for nested types above a certain level.

@Septias
Copy link

Septias commented Dec 14, 2023

Do you use it regularly and would you advise others to do so aswell? @omentic

@omentic
Copy link
Contributor Author

omentic commented Dec 14, 2023

I mean, it's fine, it looks just like the above picture. I do not write Agda regularly in Helix and I would not advise others to do so as well because Helix lacks support for Unicode input, and Unicode input is required to write Agda.

When a snippets system lands, it'd be fine, I guess: but without a "proof assistant mode" or similar not great.

pascalkuthe
pascalkuthe previously approved these changes Dec 15, 2023
@pascalkuthe
Copy link
Member

This needs co flicts resolved before being g merged

@the-mikedavis the-mikedavis dismissed stale reviews from pascalkuthe and themself via 267ebf1 December 15, 2023 15:39
@omentic
Copy link
Contributor Author

omentic commented Dec 16, 2023

(tangential re: a proof assistant mode: it's very likely it could piggyback off of debug mode, before or after a redesign. i've had no time to poke around and prototype something, unfortunately, but might in the far future...)

@pascalkuthe pascalkuthe merged commit c56cd6e into helix-editor:master Dec 16, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
* agda language support (wip)

* improve highlights

* disable agda-language-server

* minor addendum to documentation

* cargo xtask docgen

* oh i can just do this neat

* minor comment cleanup

* upstream updated

* imports: missed a spot

---------

Co-authored-by: Michael Davis <[email protected]>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* agda language support (wip)

* improve highlights

* disable agda-language-server

* minor addendum to documentation

* cargo xtask docgen

* oh i can just do this neat

* minor comment cleanup

* upstream updated

* imports: missed a spot

---------

Co-authored-by: Michael Davis <[email protected]>
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* agda language support (wip)

* improve highlights

* disable agda-language-server

* minor addendum to documentation

* cargo xtask docgen

* oh i can just do this neat

* minor comment cleanup

* upstream updated

* imports: missed a spot

---------

Co-authored-by: Michael Davis <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* agda language support (wip)

* improve highlights

* disable agda-language-server

* minor addendum to documentation

* cargo xtask docgen

* oh i can just do this neat

* minor comment cleanup

* upstream updated

* imports: missed a spot

---------

Co-authored-by: Michael Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants