Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command to cycle through version control conflict markers #4708

Closed

Conversation

wes-adams
Copy link
Contributor

Issue: #4647

@wes-adams wes-adams changed the title Add new command to cycle through version control conflict markers DRAFT: Add new command to cycle through version control conflict markers Nov 11, 2022
@archseer
Copy link
Member

Does this need to be a new keybind? We could structure it as a macro that does something like /<<<<<<<

@wes-adams
Copy link
Contributor Author

Does this need to be a new keybind? We could structure it as a macro that does something like /<<<<<<<

good idea. i'll explore that.

@pascalkuthe
Copy link
Member

With #4650 we get this sort of for free aswell (at least for git). Git refuses to perform a merge/rebase if the work tree is not clean so conflict markers will be the only change that shows up against HEAD

@wes-adams
Copy link
Contributor Author

it sounds like this merge request might be duplicating work, but i wanted to see it through regardless to learn more about how the project works.

i've tested this feature. it seems to work well.

https://asciinema.org/a/GXSmICT22D1OOY7VoXNQCsvAt

@wes-adams wes-adams changed the title DRAFT: Add new command to cycle through version control conflict markers Add new command to cycle through version control conflict markers Nov 11, 2022
@wes-adams wes-adams force-pushed the jump-conflict-markers branch 3 times, most recently from 0863ff8 to 92c528e Compare November 11, 2022 15:26
@pascalkuthe
Copy link
Member

closing this as stale. Both regex search and ]g can cover this usecase so I don't see us aadding a dedicated feature.

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants