Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ]n and [n to jump between conflict markers #4647

Closed
ocharles opened this issue Nov 8, 2022 · 9 comments
Closed

Add ]n and [n to jump between conflict markers #4647

ocharles opened this issue Nov 8, 2022 · 9 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@ocharles
Copy link
Contributor

ocharles commented Nov 8, 2022

vim-unimpaired adds ]n and [n to navigate SCM conflict markers. It'd be great to have this navigation feature in Helix, too!

@ocharles ocharles added the C-enhancement Category: Improvements label Nov 8, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Nov 8, 2022
@wes-adams
Copy link
Contributor

i'm gonna take a stab at this one

@ocharles
Copy link
Contributor Author

ocharles commented Nov 9, 2022

I look forward to seeing what you come up with! I don't know any Rust but I'd love to see how this looks, then maybe I can contribute one day :)

@wes-adams
Copy link
Contributor

brace yourself....

Kazam_screencast_00000.mp4

@wes-adams
Copy link
Contributor

the pull request is very much in draft status. it needs to be cleaned up.

after more trial and error and failing than i'd like to admit, it finally worked, so i pushed what i had.

i'll get it cleaned up, and then get feedback.

@ocharles
Copy link
Contributor Author

Great work!

wes-adams pushed a commit to wes-adams/helix that referenced this issue Nov 11, 2022
@wes-adams
Copy link
Contributor

cleaned up the merge request

search works in both directions

https://asciinema.org/a/GXSmICT22D1OOY7VoXNQCsvAt

wes-adams pushed a commit to wes-adams/helix that referenced this issue Nov 11, 2022
wes-adams pushed a commit to wes-adams/helix that referenced this issue Nov 11, 2022
wes-adams pushed a commit to wes-adams/helix that referenced this issue Nov 11, 2022
wes-adams pushed a commit to wes-adams/helix that referenced this issue Nov 11, 2022
wes-adams pushed a commit to wes-adams/helix that referenced this issue Nov 14, 2022
@wes-adams
Copy link
Contributor

wes-adams commented Nov 15, 2022

i think this issue might be dead. seems that this feature is provided in a separate PR: #4650

@ocharles - maybe pull #4650 and verify that it satisfies this issue?

fwiw my work is here: #4708

@ocharles
Copy link
Contributor Author

@wes-adams I don't think #4650 is a satisfactory fix for me. I use three-way conflict markers, and ]g doesn't seem to take me to each individual section, whereas your PR does. I'll try and put an asciinema together, but I don't think it's that #4650 does anything wrong, it's just doing something different.

@pascalkuthe
Copy link
Member

@ocharles that is already covered by searching with / <<<<<< as mentioned in #4708. In fact that is more ore less exactly what that PR was doing. If it's something you need frequently you can already bind that search to a key.
I think this feature is a bit too specific for core and already covered by other feature. In fact they cover it better because they support jumping to both the next change with #4708 or the next section with / <<<<<< depending on your needs (I use both often)

@helix-editor helix-editor locked and limited conversation to collaborators Apr 16, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10461 Apr 16, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

4 participants