Trim leading whitespaces in file search #2585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
the
S-waiting-on-review
|
This doesn't affect just file search though, but anything using the picker. Using space at the start of a search query can also be intentional: it's fuzzy search so it could just indicate some text needs to be preceded by a space. |
the-mikedavis
removed
the
S-waiting-on-review
schoenenberg
reviewed
Jun 2, 2022
| @@ -349,7 +349,7 @@ impl<T> Picker<T> { | |||
| pub fn score(&mut self) { | |||
| let now = Instant::now(); | |||
|
|
|||
| let pattern = self.prompt.line(); | |||
| let pattern = &self.prompt.line().trim_start().to_string(); | |||
There was a problem hiding this comment.
The to_string() allocation is only necessary for line 422, which does another clone. I would remove here the &...to_string() and put in 422 self.previous_pattern = pattern.to_string();
|
Closing since this is intentional behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2564