Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim leading space in file picker search #2564

Closed
aral opened this issue May 25, 2022 · 4 comments
Closed

Trim leading space in file picker search #2564

aral opened this issue May 25, 2022 · 4 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@aral
Copy link
Contributor

aral commented May 25, 2022

Leading space in the file picker search can be trimmed to improve the experience.

e.g., your project structure:

some-file.js

Search box:

 some

Will not match some-file.js due to the leading space (which could have been accidentally entered). Since leading spaces are not allowed in file names, they can be trimmed to provide a better experience in this edge case.

Priority: low.

@aral aral added the C-enhancement Category: Improvements label May 25, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label May 25, 2022
@sudormrfbin sudormrfbin added E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors labels May 26, 2022
@lunagl
Copy link
Contributor

lunagl commented May 27, 2022

In what context are file names with leading spaces not allowed? On most Unix-like systems a filename may contain any bytes apart from '/' and 0.

Edit: Even with such filenames it could be useful to trim input, as it is indeed a very uncommon thing to have and those files will still be found

@archseer
Copy link
Member

The search is fuzzy though: test could mean I'm trying to match my test.txt.

@the-mikedavis
Copy link
Member

Hmm yeah you may want to search for a space follow by a suffix. There is related discussion in #2290 of handling spaces in the picker.

@kirawi
Copy link
Member

kirawi commented Nov 10, 2022

Resolved by #3969

@kirawi kirawi closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants