Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap selection in <tag>, change surrounding <tag> and delete surrounding <tag> #12055

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
3882bf9
feat: create branch for surround implementation for x
nikitarevenco Nov 11, 2024
c586e41
refactor: add_surrounding_impl extract main logic into an fn
nikitarevenco Nov 11, 2024
d739761
docs: add documentation
nikitarevenco Nov 11, 2024
b126d9a
refactor: make surround_add use surround_add_impl in all of its brancehs
nikitarevenco Nov 11, 2024
089c202
refactor: remove unnecessary abstraction (create_surround_prompt)
nikitarevenco Nov 11, 2024
c620860
feat: complete implementation for adding surrounding tag
nikitarevenco Nov 11, 2024
59df1fe
fix: remove misleading textobject "x" mention
nikitarevenco Nov 11, 2024
f8cace7
docs: add comments describing algorithm for replacing character
nikitarevenco Nov 11, 2024
3cb8519
docs: add comments describing algorithm
nikitarevenco Nov 11, 2024
abe3210
feat: add basic hard-coded implementation for replace tag
nikitarevenco Nov 12, 2024
12d9fce
feat: add function to get next tag's position and test for it
nikitarevenco Nov 12, 2024
c45f230
test: add some extra tests
nikitarevenco Nov 12, 2024
5f4c462
feat: prev_tag finder passes tests
nikitarevenco Nov 12, 2024
93fc1af
feat: create skeleton for the replacement implementation
nikitarevenco Nov 12, 2024
cfc49f7
docs: add doc comments to new functions
nikitarevenco Nov 12, 2024
757ad23
refactor: remove loop labels and return early instead
nikitarevenco Nov 12, 2024
4908453
chore: remove unused function
nikitarevenco Nov 12, 2024
5a61331
chore: remove unused comment
nikitarevenco Nov 12, 2024
6d671e4
feat: remove unused comments
nikitarevenco Nov 12, 2024
b77e09d
chore: remove empty file
nikitarevenco Nov 12, 2024
f52b500
feat: remove unused comments
nikitarevenco Nov 12, 2024
12aa006
feat: complete implementation for getting surrounding tag
nikitarevenco Nov 12, 2024
db3202b
fix: infinite loop
nikitarevenco Nov 12, 2024
a6ab0fe
feat: complete feature for find_nth_nearest_tag
nikitarevenco Nov 13, 2024
b78a777
feat: correct handling of nested tags
nikitarevenco Nov 13, 2024
89fe2ff
test: use new util function to test ranges of html tags and their names
nikitarevenco Nov 13, 2024
f16aa7b
test: add several more tests
nikitarevenco Nov 13, 2024
dfd1252
chore: remove "pub" keyword from functions which do not need export
nikitarevenco Nov 13, 2024
74b8ca9
feat: add basic core functionality to replace Tag with another
nikitarevenco Nov 13, 2024
b2f1bb8
fix: handle pair not found error gracefully
nikitarevenco Nov 13, 2024
6f6ceda
fix: add + 1 to head for every range
nikitarevenco Nov 13, 2024
6e4d022
feat: complete implementation for replace surrounding tag
nikitarevenco Nov 13, 2024
2a61b11
feat: add delete surrounding tag functionality
nikitarevenco Nov 13, 2024
3633c8c
fix: panic which occured if cursors overlapped
nikitarevenco Nov 13, 2024
7f9e761
fix: panic which occured if ranges overlapped
nikitarevenco Nov 13, 2024
d24677d
refactor: move overlap check into find_nth_tag fn
nikitarevenco Nov 14, 2024
a88ffcd
test: refactored selections and expectations util to return only 1 range
nikitarevenco Nov 14, 2024
c3a3e48
refactor: extract while loop logic into separate variable
nikitarevenco Nov 14, 2024
dd3251d
perf: use HashSet to filter out tags which are not in both collections
nikitarevenco Nov 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading