Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrap selection in <tag>, change surrounding <tag> and delete surrounding <tag> #12055

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

feat: wrap selection in <tag>, change surrounding <tag> and delete surrounding <tag> #12055

wants to merge 39 commits into from
+670 −78

Commits on Nov 11, 2024

  1. feat: create branch for surround implementation for x

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3882bf9 View commit details
    Browse the repository at this point in the history

  2. refactor: add_surrounding_impl extract main logic into an fn

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c586e41 View commit details
    Browse the repository at this point in the history

  3. docs: add documentation

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d739761 View commit details
    Browse the repository at this point in the history

  4. refactor: make surround_add use surround_add_impl in all of its brancehs

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b126d9a View commit details
    Browse the repository at this point in the history

  5. refactor: remove unnecessary abstraction (create_surround_prompt)

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    089c202 View commit details
    Browse the repository at this point in the history

  6. feat: complete implementation for adding surrounding tag

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c620860 View commit details
    Browse the repository at this point in the history

  7. fix: remove misleading textobject "x" mention

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    59df1fe View commit details
    Browse the repository at this point in the history

  8. docs: add comments describing algorithm for replacing character

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f8cace7 View commit details
    Browse the repository at this point in the history

  9. docs: add comments describing algorithm

    @nikitarevenco
    nikitarevenco committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3cb8519 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. feat: add basic hard-coded implementation for replace tag

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    abe3210 View commit details
    Browse the repository at this point in the history

  2. feat: add function to get next tag's position and test for it

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    12d9fce View commit details
    Browse the repository at this point in the history

  3. test: add some extra tests

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c45f230 View commit details
    Browse the repository at this point in the history

  4. feat: prev_tag finder passes tests

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5f4c462 View commit details
    Browse the repository at this point in the history

  5. feat: create skeleton for the replacement implementation

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    93fc1af View commit details
    Browse the repository at this point in the history

  6. docs: add doc comments to new functions

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    cfc49f7 View commit details
    Browse the repository at this point in the history

  7. refactor: remove loop labels and return early instead

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    757ad23 View commit details
    Browse the repository at this point in the history

  8. chore: remove unused function

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4908453 View commit details
    Browse the repository at this point in the history

  9. chore: remove unused comment

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5a61331 View commit details
    Browse the repository at this point in the history

  10. feat: remove unused comments

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6d671e4 View commit details
    Browse the repository at this point in the history

  11. chore: remove empty file

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b77e09d View commit details
    Browse the repository at this point in the history

  12. feat: remove unused comments

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f52b500 View commit details
    Browse the repository at this point in the history

  13. feat: complete implementation for getting surrounding tag

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    12aa006 View commit details
    Browse the repository at this point in the history

  14. fix: infinite loop

    @nikitarevenco
    nikitarevenco committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    db3202b View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. feat: complete feature for find_nth_nearest_tag

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a6ab0fe View commit details
    Browse the repository at this point in the history

  2. feat: correct handling of nested tags

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b78a777 View commit details
    Browse the repository at this point in the history

  3. test: use new util function to test ranges of html tags and their names

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    89fe2ff View commit details
    Browse the repository at this point in the history

  4. test: add several more tests

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f16aa7b View commit details
    Browse the repository at this point in the history

  5. chore: remove "pub" keyword from functions which do not need export

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dfd1252 View commit details
    Browse the repository at this point in the history

  6. feat: add basic core functionality to replace Tag with another

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    74b8ca9 View commit details
    Browse the repository at this point in the history

  7. fix: handle pair not found error gracefully

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b2f1bb8 View commit details
    Browse the repository at this point in the history

  8. fix: add + 1 to head for every range

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6f6ceda View commit details
    Browse the repository at this point in the history

  9. feat: complete implementation for replace surrounding tag

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6e4d022 View commit details
    Browse the repository at this point in the history

  10. feat: add delete surrounding tag functionality

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2a61b11 View commit details
    Browse the repository at this point in the history

  11. fix: panic which occured if cursors overlapped

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3633c8c View commit details
    Browse the repository at this point in the history

  12. fix: panic which occured if ranges overlapped

    @nikitarevenco
    nikitarevenco committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7f9e761 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. refactor: move overlap check into find_nth_tag fn

    @nikitarevenco
    nikitarevenco committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d24677d View commit details
    Browse the repository at this point in the history

  2. test: refactored selections and expectations util to return only 1 range

    @nikitarevenco
    nikitarevenco committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a88ffcd View commit details
    Browse the repository at this point in the history

  3. refactor: extract while loop logic into separate variable

    @nikitarevenco
    nikitarevenco committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c3a3e48 View commit details
    Browse the repository at this point in the history

  4. perf: use HashSet to filter out tags which are not in both collections

    @nikitarevenco
    nikitarevenco committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    dd3251d View commit details
    Browse the repository at this point in the history