Fix menus with borders enabled and popups opening below with less spa… #10566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
reviewed
Apr 23, 2024
| viewport.height > rel_y + MIN_HEIGHT | ||
| } else { | ||
| // non-menu popups need 6 height below | ||
| viewport.height > rel_y + MIN_HEIGHT + 2 |
There was a problem hiding this comment.
Why the + 2 in the non-memu case?
| (child_size.1 <= MIN_HEIGHT && viewport.height > rel_y + MIN_HEIGHT) | ||
| || (child_size.1 > MIN_HEIGHT && viewport.height > rel_y + MIN_HEIGHT + 2) | ||
| } else if is_menu { | ||
| viewport.height > rel_y + MIN_HEIGHT |
There was a problem hiding this comment.
Why does the menu without popul case need a special case?
| let can_put_below = viewport.height > rel_y + MIN_HEIGHT; | ||
| let can_put_below = if is_menu && editor.menu_border() { | ||
| // in case of menu borders, we dont want to put it below if it would show two lines less | ||
| (child_size.1 <= MIN_HEIGHT && viewport.height > rel_y + MIN_HEIGHT) |
There was a problem hiding this comment.
J think this is a bit hard to understand. If I understand the code correctly a simpler way to I.plement this would be `let min_height = if is_menu && has_border && child_size.1 > MIN_HEIGHT { MIN_HRIGHT + 2 } else { MIN_HEIGHT };
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce than needed
fixes #10553
and also fixes:
before:
after: