Support scrolling popup contents using mouse #10053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudormrfbin
changed the title
the-mikedavis
added
the
S-waiting-on-review
pascalkuthe
approved these changes
Mar 31, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Apr 3, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
5 tasks
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Extract popup scrolling code into named functions * Scroll popup contents on mouse scroll event * Ignore mouse events outside the popup * Remove unneeded return statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, long time no see :) This PR adds support for scrolling through the popup with the mouse as an alternative to the already existing
C-dandC-ubindings. Scrolling is only done ifhas_scrollbaristrue.For ignoring mouse events that fall outside the frame of the popup, the rendering area
Rectof the popup is stored in the struct. This feels hacky but I couldn't think of any other way to retrieve the area insidehandle_event().The PR has been organized into commits that can be easily reviewed. Some commits are only concerned with moving code around with no new functionality introduced.