Improve popup positioning and multi popup interactions

[sudormrfbin]

Popups as a whole have some usability problems as of now (most of them due to the window being small):

• Rendering on top of the cursor and obstructing the current editing line, commonly happens with auto completion popup
• Auto completion documentation taking up half the screen and potentially rendering over the cursor (Refactor completion doc popup and fix positioning #5842)
• Signature help overlapping with auto completion popup (Only render the auto-complete menu if it intersects with signature help #5523)
• Scrolling inside the popup doesn't scroll the contents (Support scrolling popup contents using mouse #10053)
• Scrolling/clicking outside the popup doesn't dismiss it (Handle mouse events based on pointer focus for popups #10126)

[faldor20]

I have experienced a few of these and 1. is by far the most problematic. It just makes completion unusable in some scenarios

[kirawi]

There is also #5529

[wes-adams]

can this be broken into multiple issues/fixes?
i'd like to attempt a fix for

1. Rendering on top of the cursor and obstructing the current editing line, commonly happens with auto completion popup

[kirawi]

It looks like a PR for that was merged recently: #5842

[sudormrfbin]

It was mostly fixed by #5842, but there are still some cursor overlapping edge cases caused by position calculation. Soft wrap also seems to trigger the overlapping since the current document line does not necessarily correspond to the current screen line anymore (\cc @pascalkuthe).

[pascalkuthe]

It was mostly fixed by #5842, but there are still some cursor overlapping edge cases caused by position calculation. Soft wrap also seems to trigger the overlapping since the current document line does not necessarily correspond to the current screen line anymore (\cc @pascalkuthe).

I reviewed the code again and it seems to already account for softwrap correctly as it uses screen_coords_at_pos to calculate the position (there are some minor nits I noticed that could be simplified but nothing that is really important).
I did some testing and couldn't find an example of the cursor itself being overlapped. There were examples where the previous visual line (that was still part of the document line that contains the cursor) was being overlapped. Is that what you mean @sudormrfbin? I think always leaving the entire document line free is not realistic because a single document line can cover the entire screen with softwrap but we could do something like ensuring that the visual line before the cursor is not overlapped if it belongs to the same document line.

[wes-adams]

i pulled master and tried to repro number 1, the overlap issues that i am sure i used to encounter... and i have to agree! looks like this was fixed.

[ghost]

Posting here bc it seems to be n.3, let me know if I need to open a new issue.

Docs popup shadows the auto-completion. I am not triggering the docs popup manually, albeit I have auto-complete = true in the config.

PS. This only happens when the line is near the bottom of the window, so a current workaround would be to scroll the line towards the centre of the screen.

Demo:

Screen.Recording.2023-03-19.at.13.06.03.mov

[pascalkuthe]

see #10257 and particularly #10257 (comment) relevant (latter contains descirpiton of a popupmanager that I think can resolve this issue)

[ondrej-ivanko]

I can reproduce point 2 of this issue. It happens when I'm editing line close to the top of the viewport.

and

In this case there are lot of func parameters. The popup of object help is really strange. The cause might be the border rendered around the popup help. I remember this functionality was implemented few months ago.

When I edit the same line at bottom of viewport, the problem disappears

Maybe in case two popups overlaps there can be some sort of rendering prioritization. First render object help, than autocompletion popup on top of it.