-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve popup positioning and multi popup interactions #5827
Comments
I have experienced a few of these and 1. is by far the most problematic. It just makes completion unusable in some scenarios |
There is also #5529 |
can this be broken into multiple issues/fixes?
|
It looks like a PR for that was merged recently: #5842 |
It was mostly fixed by #5842, but there are still some cursor overlapping edge cases caused by position calculation. Soft wrap also seems to trigger the overlapping since the current document line does not necessarily correspond to the current screen line anymore (\cc @pascalkuthe). |
I reviewed the code again and it seems to already account for softwrap correctly as it uses |
i pulled |
Posting here bc it seems to be n.3, let me know if I need to open a new issue. Docs popup shadows the auto-completion. I am not triggering the docs popup manually, albeit I have auto-complete = true in the config. PS. This only happens when the line is near the bottom of the window, so a current workaround would be to scroll the line towards the centre of the screen. Demo: Screen.Recording.2023-03-19.at.13.06.03.mov |
see #10257 and particularly #10257 (comment) relevant (latter contains descirpiton of a popupmanager that I think can resolve this issue) |
I can reproduce point 2 of this issue. It happens when I'm editing line close to the top of the viewport. and In this case there are lot of func parameters. The popup of object help is really strange. The cause might be the border rendered around the popup help. I remember this functionality was implemented few months ago. When I edit the same line at bottom of viewport, the problem disappears Maybe in case two popups overlaps there can be some sort of rendering prioritization. First render object help, than autocompletion popup on top of it. |
Popups as a whole have some usability problems as of now (most of them due to the window being small):
The text was updated successfully, but these errors were encountered: