chore(scripts): restore PR #65 (Q8_0 default + --target flag) lost in ht rewrite#88
Closed
marksverdhei wants to merge 1 commit into
Closed
chore(scripts): restore PR #65 (Q8_0 default + --target flag) lost in ht rewrite#88marksverdhei wants to merge 1 commit into
marksverdhei wants to merge 1 commit into
Conversation
Per Markus 2026-06-04: DFlash quality measurement should use a Q8_0 target rather than Q4_K_M, since Q4_K_M introduces enough target-side quantization noise to confound DFlash's own accept-rate signal. Q8_0 fits in 38 GB total, well within titan A100 80 GB. * Default `TARGET` is now `gemma-4-31B-it-Q8_0.gguf`. Override via `--target PATH` or `DFLASH_BENCH_TARGET` env var. * Also added `DFLASH_BENCH_DRAFTER_DIR` env var for consistency. * Comment block documents VRAM math for Q4_K_M / Q8_0 / BF16 targets so future runs can pick the right card.
Author
|
Retracting — false positive. My local This is exactly the failure mode Apologies for the noise; deleting the branch. |
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Epoch #86 task 3 (bench-dflash.sh drift check) surfaced this: PR #65 ("scripts(dflash): switch default bench target to Q8_0 + --target flag") was merged 2026-06-04 19:39 (merge commit `09b2124f`), but its content is missing from the current `origin/ht` tip. The script on ht still has the pre-#65 state — `TARGET=...gemma-4-31B-it-Q4_K_M.gguf` hardcoded, no `--target` flag, no `DFLASH_BENCH_TARGET` env var.
Likely cause: the 2026-06-04 ht history rewrite happened around the same time and didn't carry PR #65's diff through the 8-commit consolidation. (Spot-checked PRs #52, #54, #55 from the same window — those are all still present under different commit hashes, so this is genuinely the one that fell through.)
Fix
Cherry-picked `2079a61de` ("scripts(dflash): switch default bench target to Q8_0 + --target flag") directly onto ht. Same diff Markus originally approved; no other changes.
Test plan
Audit follow-up
Suggest tagging `ht-pre-rewrite-2026-06-04` (already exists per memory) as the canonical reference for "what content was present pre-rewrite" — so future rewrites can sanity-check against this list. Filing as a low-priority observation rather than a PR.
🤖 Generated with Claude Code