Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Debug play #5269

Merged
merged 8 commits into from
Mar 18, 2024
Merged

🪲 Debug play #5269

merged 8 commits into from
Mar 18, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Mar 14, 2024

Adds the play builtin function to both run and debug paths, so now we're able to debug the play command. Also fixes the highlighting of variables within the play command, as well as fixing the highlighting of the lines containing the play command while debugging.

Fixes #5111

How to test

  • Automated tests should pass
  • Go to level 2 and debug this code:
note is C1
play note
play C2

Also check that the note variable is colored blue.

@Felienne
Copy link
Member

Nice work @jpelay! Just one thing (my fault, of course haha!) In the variables list, chosen_note is also shown because we use it in hedy.py:

hedy/hedy.py

Line 1705 in 8a2c067

chosen_note = note.children[0] if isinstance(note, Tree) else note

image

Can we escape it? I guess there is a list of to be escaped variables somewhere already?

@jpelay
Copy link
Member Author

jpelay commented Mar 15, 2024

Can we escape it? I guess there is a list of to be escaped variables somewhere already?

Done! Indeed there's a list here in case you want to check it out!

Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 179c723 into main Mar 18, 2024
12 checks passed
@mergify mergify bot deleted the debug_play branch March 18, 2024 12:19
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Can't debug play
2 participants