Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Can't debug play #5111

Closed
jpelay opened this issue Feb 9, 2024 · 0 comments · Fixed by #5269
Closed

🪲 Can't debug play #5111

jpelay opened this issue Feb 9, 2024 · 0 comments · Fixed by #5269
Labels
bug Something isn't working

Comments

@jpelay
Copy link
Member

jpelay commented Feb 9, 2024

There's no possibility to debug the debug the play command currently, due to it being added to the Sk object only in the run if.
@jpelay jpelay added the bug Something isn't working label Feb 9, 2024
@jpelay jpelay mentioned this issue Feb 9, 2024
Closed
@Felienne Felienne mentioned this issue Mar 7, 2024
Closed
@jpelay jpelay mentioned this issue Mar 14, 2024
Merged
@mergify mergify bot closed this as completed in #5269 Mar 18, 2024
mergify bot pushed a commit that referenced this issue Mar 18, 2024
@jpelay
🪲 Debug play (#5269)
179c723 
Adds the `play` builtin function to both `run` and  `debug` paths, so now we're able to debug the play command. Also fixes the highlighting of variables within the play command, as well as fixing the highlighting of the lines containing the play command while debugging.

Fixes  #5111 

**How to test**
*  Automated tests should pass
* Go to level 2 and debug this code:

```
note is C1
play note
play C2
```

Also check that the `note` variable is colored blue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Hedy organization board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪲 Debug play hedyorg/hedy
🪲 Debug play hedyorg/hedy
1 participant
@jpelay